-
Notifications
You must be signed in to change notification settings - Fork 25.3k
ES|QL: Add docs for FORK #130314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES|QL: Add docs for FORK #130314
Conversation
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
docs/reference/query-languages/esql/_snippets/lists/processing-commands.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I made a couple of comments earlier outside of a proper review, one of which should fix the broken build.
I have a few minor wording suggestions here, but otherwise I have 2 general remarks:
- Maybe we could have a bit more "Why Use FORK?" information at the outset.
- Explain when to use FORK (applying different processing logic to the same dataset)
- Advantages over multiple separate queries or complex CASE statements
- Common use cases
- Add More Examples
- Include comparison examples showing FORK vs alternatives
But that might be out of scope for initial release, so it could just be future food for thought :)
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
…-commands.md Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just a few more suggestions to basically group related info (branch id, column handling, row ordering) in a more readable fashion. I'd still like to see a couple more illustrative examples but understand this might be good enough for now. :)
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Liam Thompson <[email protected]>
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
…fork.md Co-authored-by: Liam Thompson <[email protected]>
💚 Backport successful
|
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
#121950
Does what is says.
Now that FORK is out of snapshot and in tech preview, we need to document the feature.