Skip to content

Conversation

ivancea
Copy link
Contributor

@ivancea ivancea commented Oct 8, 2025

Draft

This PR should cover until the query setting is accessible from the Configuration. Merging it before that could mean merging APIs that actually don't fit well in some way.

PR roadmap

  • Convert the query settings into something similar to the cluster setting objects, having an automatic parser to convert them to values and so on (Example)
    • Reusing those classes look not too straightforward, as we use ESQL Expressions, not strings
    • Add a parser and a default value. Because they're generic, I had to transform the enum into static fields
    • Organize tests to easily add more settings there
  • Add the values to the Configuration object, with a simple API like configuration.getSetting(QuerySettings.TIME_ZONE)
    • For that, the QuerySettings class must be visible from wherever it's used, or the constants should be localized in some common place. Check this!
    • TransportVersion to share them

Depending on the size of the final PR, I may move the time_zone related things to another one.

Copy link
Contributor

github-actions bot commented Oct 8, 2025

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant