Fix dependency reporting #136209
Open
Fix dependency reporting #136209
+127
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
commented
Oct 9, 2025
| var runtimeConfiguration = project.getConfigurations().getByName(JavaPlugin.RUNTIME_CLASSPATH_CONFIGURATION_NAME); | ||
| t.getRuntimeArtifacts().set(project.getProviders().provider(() -> runtimeConfiguration.getIncoming().getArtifacts())); | ||
| t.getRuntimeArtifacts() | ||
| .set(project.getProviders().provider(() -> createNonTransitiveArtifactsView(runtimeConfiguration).getArtifacts())); |
There was a problem hiding this comment.
We only care about the direct dependencies here
breskeby
commented
Oct 9, 2025
| * </ul> | ||
| */ | ||
| public abstract class DependenciesInfoTask extends ConventionTask { | ||
| @CacheableTask |
There was a problem hiding this comment.
since we removed the convention mapping we can make that task cacheable
breskeby
commented
Oct 9, 2025
| 'https://oss-dependencies.elastic.co/red-hat-universal-base-image-minimal/9/ubi-minimal-9-source.tar.gz' | ||
| ] | ||
| additionalLines << rhelUbiFields.join(',') | ||
| doLast { |
There was a problem hiding this comment.
just another safety net to capture suspicious change in behaviour
breskeby
force-pushed
the
fix-dependency-reporting
branch
2 times, most recently
from
8d4d7c6 to
46e91f1
Compare
jozala
reviewed
Oct 9, 2025
Comment on lines
+101
to
+102
| .map(mcaId -> (ModuleComponentArtifactIdentifier) mcaId) | ||
| .map(it -> it.getComponentIdentifier()) |
There was a problem hiding this comment.
Do I understand correctly this part was the root cause of missing dependencies in the report? Did Gradle change something in the identifiers hierarchy?
This has been broken since 9.0.3. likely due to some swallowed api change in Gradle. This fixes and adds test coverage to dependency reporting used in DRA artifacts building Fix interdependency to Licenses task
breskeby
force-pushed
the
fix-dependency-reporting
branch
from
4855ac1 to
f252c2d
Compare
jozala
approved these changes
Oct 9, 2025
breskeby
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been broken since 9.0.3. likely due to some swallowed api change in
Gradle. This fixes and adds test coverage to dependency reporting used in DRA
artifacts building