Skip to content

Remove cluster update task when task times out #21578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2016

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Nov 15, 2016

Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.

Relates #21568

Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a minor comment.

}
}
if (toRemove.isEmpty() == false) {
ClusterStateTaskExecutor<T> clusterStateTaskExecutor = toRemove.iterator().next().executor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: toRemove.iterator().next().executor -> toRemove.get(0).executor

@jasontedor
Copy link
Member

Thanks @ywelsch. I think is good to address the problem, and we can think longer term about how to simplify this specific code in the cluster service.

@ywelsch ywelsch merged commit 40e0162 into elastic:master Nov 15, 2016
@ywelsch
Copy link
Contributor Author

ywelsch commented Nov 15, 2016

Thanks @jasontedor. I'll leave it running on CI tonight and backport tomorrow.

ywelsch added a commit that referenced this pull request Nov 16, 2016
Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
ywelsch added a commit that referenced this pull request Nov 16, 2016
Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
ywelsch added a commit that referenced this pull request Nov 16, 2016
Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
@ywelsch
Copy link
Contributor Author

ywelsch commented Nov 16, 2016

backport complete (5.x: daf7dbe, 5.0: bbf52d1, 2.4: 161c65a)

jasontedor added a commit that referenced this pull request Nov 16, 2016
* master: (22 commits)
  Add proper toString() method to UpdateTask (#21582)
  Fix `InternalEngine#isThrottled` to not always return `false`. (#21592)
  add `ignore_missing` option to SplitProcessor (#20982)
  fix trace_match behavior for when there is only one grok pattern (#21413)
  Remove dead code from GetResponse.java
  Fixes date range query using epoch with timezone (#21542)
  Do not cache term queries. (#21566)
  Updated dynamic mapper section
  Docs: Clarify date_histogram bucket sizes for DST time zones
  Handle release of 5.0.1
  Fix skip reason for stats API parameters test
  Reduce skip version for stats API parameter tests
  Strict level parsing for indices stats
  Remove cluster update task when task times out (#21578)
  [DOCS] Mention "all-fields" mode doesn't search across nested documents
  InternalTestCluster: when restarting a node we should validate the cluster is formed via the node we just restarted
  Fixed bad asciidoc in boolean mapping docs
  Fixed bad asciidoc ID in node stats
  Be strict when parsing values searching for booleans (#21555)
  Fix time zone rounding edge case for DST overlaps
  ...
@clintongormley clintongormley added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. and removed :Cluster labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug critical :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v2.4.2 v5.0.2 v5.1.1 v6.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants