-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Remove cluster update task when task times out #21578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cluster update task when task times out #21578
Conversation
Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a minor comment.
} | ||
} | ||
if (toRemove.isEmpty() == false) { | ||
ClusterStateTaskExecutor<T> clusterStateTaskExecutor = toRemove.iterator().next().executor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: toRemove.iterator().next().executor
-> toRemove.get(0).executor
Thanks @ywelsch. I think is good to address the problem, and we can think longer term about how to simplify this specific code in the cluster service. |
Thanks @jasontedor. I'll leave it running on CI tonight and backport tomorrow. |
Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
* master: (22 commits) Add proper toString() method to UpdateTask (#21582) Fix `InternalEngine#isThrottled` to not always return `false`. (#21592) add `ignore_missing` option to SplitProcessor (#20982) fix trace_match behavior for when there is only one grok pattern (#21413) Remove dead code from GetResponse.java Fixes date range query using epoch with timezone (#21542) Do not cache term queries. (#21566) Updated dynamic mapper section Docs: Clarify date_histogram bucket sizes for DST time zones Handle release of 5.0.1 Fix skip reason for stats API parameters test Reduce skip version for stats API parameter tests Strict level parsing for indices stats Remove cluster update task when task times out (#21578) [DOCS] Mention "all-fields" mode doesn't search across nested documents InternalTestCluster: when restarting a node we should validate the cluster is formed via the node we just restarted Fixed bad asciidoc in boolean mapping docs Fixed bad asciidoc ID in node stats Be strict when parsing values searching for booleans (#21555) Fix time zone rounding edge case for DST overlaps ...
Fixes an issue where the cluster service does not remove an update task from its internal data structures that are used for batching cluster state updates.
Relates #21568