Remove uniqueness constraint for API key name and make it optional #47549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Contributor
Author
|
Hi @jkakavas Could you please review when you get some time, I would like to get this in for 7.5. Thank you for your time. |
jkakavas
approved these changes
Oct 11, 2019
Contributor
jkakavas
left a comment
jkakavas
left a comment
There was a problem hiding this comment.
LGTM, don't forget to disable BWC tests in build.gradle before merging this
...k/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/ApiKeyIntegTests.java
Show resolved
Hide resolved
Co-Authored-By: Ioannis Kakavas <[email protected]>
Co-Authored-By: Ioannis Kakavas <[email protected]>
bizybot
pushed a commit
to bizybot/elasticsearch
that referenced
this pull request
Oct 12, 2019
Disable BWC for elastic#47549 Once it is merged and backported I will re-enable it.
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix |
bizybot
added a commit
that referenced
this pull request
Oct 12, 2019
Disable BWC for #47549 Once it is merged and backported I will re-enable it.
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Oct 12, 2019
…lastic#47549) Since we cannot guarantee the uniqueness of the API key `name` this commit removes the constraint and makes this field optional. Closes elastic#46646
bizybot
added a commit
that referenced
this pull request
Oct 12, 2019
Merged
howardhuanghua
pushed a commit
to TencentCloudES/elasticsearch
that referenced
this pull request
Oct 14, 2019
Disable BWC for elastic#47549 Once it is merged and backported I will re-enable it.
howardhuanghua
pushed a commit
to TencentCloudES/elasticsearch
that referenced
this pull request
Oct 14, 2019
…lastic#47549) Since we cannot guarantee the uniqueness of the API key `name` this commit removes the constraint and makes this field optional. Closes elastic#46646
Collaborator
|
Pinging @elastic/es-security (:Security/Security) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we cannot guarantee the uniqueness of the API key
namethis commit removes the constraint and makes this field optional.Closes #46646