Fix SLMSnapshotBlockingIntegTest #47941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The after snapshot action is interfering with SLM deleting snapshots here it seems, causing concurrent delete exceptions. Since these tests are now test-scoped there is no reason to run snapshot deletes after each test so we can remove them to avoid this issue. Closes #47937
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
Contributor
|
Packaging failure looks like a network and/or vagrant blip. @elasticmachine run elasticsearch-ci/packaging-sample |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample (vagrant ...) |
Contributor
Author
|
Jenkins run elasticsearch-ci/2 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
Contributor
Author
|
Thanks @gwbrown ! |
howardhuanghua
pushed a commit
to TencentCloudES/elasticsearch
that referenced
this pull request
Oct 14, 2019
The after snapshot action is interfering with SLM deleting snapshots here it seems, causing concurrent delete exceptions. Since these tests are now test-scoped there is no reason to run snapshot deletes after each test so we can remove them to avoid this issue. Closes elastic#47937
original-brownbear
added a commit
that referenced
this pull request
Oct 17, 2019
The after snapshot action is interfering with SLM deleting snapshots here it seems, causing concurrent delete exceptions. Since these tests are now test-scoped there is no reason to run snapshot deletes after each test so we can remove them to avoid this issue. Closes #47937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The after snapshot action is interfering with SLM deleting snapshots
here it seems, causing concurrent delete exceptions.
Since these tests are now test-scoped there is no reason to run
snapshot deletes after each test so we can remove them to avoid this issue.
Closes #47937