Remove assertion about GCS credentials always being null when not set explicitly #83139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
… explicetly After we fixed getting application credentials in a GCE environment in elastic#82974, we can actually get credentials set automatically when creating a new GCS client Fixes elastic#83131
arteam
force-pushed
the
gce-remove-wrong-assertions
branch
from
dbfada7 to
ad2bf62
Compare
arteam
added
the
auto-backport
idegtiarenko
approved these changes
Jan 26, 2022
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Jan 26, 2022
… explicetly (elastic#83139) After we fixed getting application credentials in a GCE environment in elastic#82974, we can actually get credentials set automatically when creating a new GCS client Fixes elastic#83131
💔 Backport failed
You can use sqren/backport to manually backport by running |
arteam
added a commit
that referenced
this pull request
Jan 26, 2022
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Jan 26, 2022
…not set explicetly (elastic#83139) Backports the following commits to 8.0: - Remove assertion about GCS credentials always being null when not set explicetly (elastic#83139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we fixed getting application credentials in a GCE environment in #82974, we can actually end up in an environment where the credentials set automatically when creating a new GCS client
Fixes #83131