Increase assertAllCancellableTasksAreCancelled timeout #89744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>test
elasticsearchmachine
added
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
kingherc
approved these changes
Aug 31, 2022
|
Thanks @kingherc. Do you know actually if backporting to 8.3 is necessary here? I have the impression that since main is now 8.5, only the CI for 8.4 will be periodically running, and there is no more 8.3 changes. |
|
@pxsalehi seeing the release schedule, I believe 8.3 may not be necessary. But feel free to check with the team as well to be certain. |
|
Yes, I thought the same. I think I'll take out the 8.3. Thanks. |
|
@elasticmachine update branch |
💔 Backport failed
You can use sqren/backport to manually backport by running |
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Aug 31, 2022
The following two failures happen rarely, but both fail in the same `assertBusy` block. I don't have a clue why, and couldn't reproduce them. Considering the amount of checks in that block, maybe a larger timeout is more suitable. (Also it seems from the test history, it is not uncommon for those tests to take 2-3s, so every few thousand runs hitting the 10s timeout seems likely, IMO!) Relates elastic#88884, elastic#88201
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 31, 2022
The following two failures happen rarely, but both fail in the same `assertBusy` block. I don't have a clue why, and couldn't reproduce them. Considering the amount of checks in that block, maybe a larger timeout is more suitable. (Also it seems from the test history, it is not uncommon for those tests to take 2-3s, so every few thousand runs hitting the 10s timeout seems likely, IMO!) Relates #88884, #88201
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Aug 31, 2022
The following two failures happen rarely, but both fail in the same `assertBusy` block. I don't have a clue why, and couldn't reproduce them. Considering the amount of checks in that block, maybe a larger timeout is more suitable. (Also it seems from the test history, it is not uncommon for those tests to take 2-3s, so every few thousand runs hitting the 10s timeout seems likely, IMO!) Relates elastic#88884, elastic#88201
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following two failures happen rarely, but both fail in the same
assertBusyblock. I don't have a clue why, and couldn't reproduce them. Considering the amount of checks in that block, maybe a larger timeout is more suitable. (Also it seems from the test history, it is not uncommon for those tests to take 2-3s, so every few thousand runs hitting the 10s timeout seems likely, IMO!)Relates #88884, #88201