Ensure tasks with banned parents always get cancelled #90188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
the
:Distributed Coordination/Task Management
elasticsearchmachine
added
v8.5.0
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
added
v8.4.3
v7.17.7
auto-backport-and-merge
>test
|
@elasticmachine update branch |
|
Thank, Armin. |
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Sep 22, 2022
The check used to entirely skip parent lookup relies on ConcurrentHashMap#isEmpty() which could return inconsistent results, and potentially skip the cancellation of a task with a banned parent upon registration, and it doesn't seem to have a benefit considering the hash code computation. Closes elastic#88201
💔 Backport failed
You can use sqren/backport to manually backport by running |
pxsalehi
added a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Sep 22, 2022
The check used to entirely skip parent lookup relies on ConcurrentHashMap#isEmpty() which could return inconsistent results, and potentially skip the cancellation of a task with a banned parent upon registration, and it doesn't seem to have a benefit considering the hash code computation. Closes elastic#88201
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2022
The check used to entirely skip parent lookup relies on ConcurrentHashMap#isEmpty() which could return inconsistent results, and potentially skip the cancellation of a task with a banned parent upon registration, and it doesn't seem to have a benefit considering the hash code computation. Closes #88201
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2022
The check used to entirely skip parent lookup relies on ConcurrentHashMap#isEmpty() which could return inconsistent results, and potentially skip the cancellation of a task with a banned parent upon registration, and it doesn't seem to have a benefit considering the hash code computation. Closes #88201 Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check used to entirely skip parent lookup relies on
ConcurrentHashMap#isEmpty()which could return inconsistent results, and potentially skip the cancellation of a task with a banned parent upon registration, as brought up by @original-brownbear, and it doesn't seem to have a benefit considering the hash code computation.Closes #88201