Skip to content

Output a consistent format when generating error json #90529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Nov 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
b0c0682
Output a consistent format when generating error json
thecoop Sep 29, 2022
4cd9a4e
Update docs/changelog/90529.yaml
thecoop Sep 29, 2022
a731fa6
Update changelog with issue number
thecoop Sep 29, 2022
cec444a
Update RestResponseTests
thecoop Sep 29, 2022
f3d60c8
PR comments
thecoop Sep 30, 2022
6bd5e56
Merge remote-tracking branch 'upstream/main' into exception-json
thecoop Sep 30, 2022
744626c
spotless
thecoop Sep 30, 2022
45b9806
Update docs/changelog/90529.yaml
thecoop Sep 30, 2022
7532693
Update docs/changelog/90529.yaml
thecoop Sep 30, 2022
1e75fce
Update docs/changelog/90529.yaml
thecoop Sep 30, 2022
750eb7d
Update changelog with change details
thecoop Sep 30, 2022
93dc953
Update docs/changelog/90529.yaml
thecoop Oct 3, 2022
d293dcb
Match the method parameter types
thecoop Oct 3, 2022
309b076
Merge remote-tracking branch 'upstream/main' into exception-json
thecoop Nov 17, 2022
ab3041c
Update docs
thecoop Nov 17, 2022
f185846
Merge branch 'main' into exception-json
thecoop Nov 17, 2022
459acf4
Update docs/changelog/90529.yaml
thecoop Feb 8, 2023
32a9f9e
Merge branch 'main' into exception-json
thecoop Feb 10, 2023
02862e9
Revert "Update docs/changelog/90529.yaml"
thecoop Feb 10, 2023
14b55f9
Update docs/changelog/90529.yaml
thecoop Apr 26, 2023
dca6d31
Merge branch 'main' into exception-json
thecoop Oct 10, 2024
a2548ab
Revert "Update docs/changelog/90529.yaml"
thecoop Oct 10, 2024
8396ba3
Merge branch 'main' into exception-json
elasticmachine Oct 10, 2024
798be45
Merge remote-tracking branch 'upstream/main' into exception-json
thecoop Oct 18, 2024
6f253c4
Add V8 rest API formats for compatibility
thecoop Oct 18, 2024
c77abde
Merge branch 'main' into exception-json
thecoop Nov 6, 2024
93da694
Add a basic deprecation warning that the JSON format is changing in v9
thecoop Oct 14, 2024
872699c
Merge branch 'main' into exception-json
thecoop Nov 13, 2024
cc2bc6a
Revert "Add a deprecation warning that the JSON format of non-detaile…
thecoop Nov 13, 2024
980a449
Propagate changes from deprecation PRs
thecoop Nov 13, 2024
76f9185
Update tests
thecoop Nov 13, 2024
4726363
Update docs/changelog/90529.yaml
thecoop Nov 13, 2024
cb964f0
Revert "Update docs/changelog/90529.yaml"
thecoop Nov 13, 2024
aef3b2d
Use more randomness in detailed parameter
thecoop Nov 13, 2024
cd81c30
splotless
thecoop Nov 13, 2024
108dd01
Update test
thecoop Nov 14, 2024
c4a929c
Merge branch 'main' into exception-json
thecoop Nov 14, 2024
9ccb15c
Don't want stray warnings here
thecoop Nov 14, 2024
66c8b91
Merge branch 'main' into exception-json
elasticmachine Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spotless
  • Loading branch information
thecoop committed Sep 30, 2022
commit 744626c8aae2c49ed05b880702924ab0e9b47fe5
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ public void testToXContent() throws IOException {
public void testGenerateFailureToXContentWithNoDetails() throws IOException {
{
Exception ex = new FileNotFoundException("foo not found");
for (int i=0; i<randomInt(10); i++) {
for (int i = 0; i < randomInt(10); i++) {
ex = new RemoteTransportException("foobar", ex);
}
assertFailureAsJson(ex, """
Expand Down Expand Up @@ -641,7 +641,7 @@ public void testGenerateFailureToXContentWithNoDetails() throws IOException {
public void testGenerateFailureToXContentWithDetails() throws IOException {
{
Exception ex = new FileNotFoundException("foo not found");
for (int i=0; i<randomInt(10); i++) {
for (int i = 0; i < randomInt(10); i++) {
ex = new RemoteTransportException("foobar", ex);
}
assertFailureAsJson(ex, """
Expand Down Expand Up @@ -686,7 +686,7 @@ public void testGenerateFailureToXContentWithDetails() throws IOException {
public void testGenerateThrowableToXContent() throws IOException {
{
Exception ex = new FileNotFoundException("foo not found");
for (int i=0; i<randomInt(10); i++) {
for (int i = 0; i < randomInt(10); i++) {
ex = new RemoteTransportException("foobar", ex);
}
assertThrowableAsJson(ex, """
Expand Down