Route stateless term vectors requests to promotable shards #94257
Conversation
dnhatn
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
I'm not super familiar with the cost of this request, but I assume we will eventually want to optimize this similar to GET #93976. Only performing on the promotable copy when required? |
|
@Tim-Brooks Thanks for the review. I can look into the optimization but this API isn't as sensitive as the GET API. |
💚 Backport successful
|
Like GET requests, we should also route term vectors requests to promotable copies in stateless. Relates elastic#93612
| } else { | ||
| return iterator; | ||
| } | ||
| return clusterService.operationRouting().useOnlyPromotableShardsForStateless(iterator); |
There was a problem hiding this comment.
@dnhatn are these changes to Get and MGet necessary for correctly routing term vector requests? Or is it just to make use of useOnlyPromotableShardsForStateless? I need to change this to route gets to search shards, and I am wondering whether this is needed/shared with term vectors or not.
There was a problem hiding this comment.
@pxsalehi The term vectors API just uses useOnlyPromotableShardsForStateless shards. Feel free to make changes to the get and mget APIs.
Like GET requests, we should also route term vectors requests to promotable copies in stateless.
Relates #93612