ESQL: Pushdown metadata attributes #98355
Conversation
This allows to push down those metadata attributes that can be pushed down. Out of the currently supported three, the only one pushed down is _index. This only supports wildcard and terms queries.
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
| @@ -7,7 +7,6 @@ | |||
|
|
|||
| package org.elasticsearch.xpack.esql.analysis; | |||
|
|
|||
| import org.elasticsearch.xpack.esql.expression.MetadataAttribute; | |||
There was a problem hiding this comment.
Spotless rearrangements (possibly due to repo's rules).
| "_index", | ||
| tuple(DataTypes.KEYWORD, true), | ||
| "_id", | ||
| tuple(DataTypes.KEYWORD, false) | ||
| tuple(DataTypes.KEYWORD, false) // actually searchable, but fielddata access on the _id field is disallowed by default |
There was a problem hiding this comment.
The _id could be pushed down, but since by default it would return an error, pushing down is disabled. This does mean however that those deployments with fielddata accessible are taxed.
| ); | ||
|
|
||
| private final boolean docValues; |
There was a problem hiding this comment.
docValues was added for future _id support. However, _id support matches by name, not by checking if the attribute has or not docValues; so scrapped and replaced with searchable.
| } else if (exp instanceof Not not) { | ||
| return canPushToSource(not.field()); | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| private static boolean canPushAttribute(Expression expression, ScalarFunction operation) { |
There was a problem hiding this comment.
Replaced (with isAttributePushable).
| if (field instanceof MetadataAttribute) { | ||
| return querySupplier.get(); // MetadataAttributes are always single valued | ||
| } | ||
| throw new IllegalStateException("Expected a FieldAttribute or MetadataAttribute but received [" + field + "]"); |
There was a problem hiding this comment.
Use EsqlIllegalArgument instead.
| public static String pushableAttributeName(TypedAttribute attribute) { | ||
| if (attribute instanceof FieldAttribute fa) { | ||
| // equality should always be against an exact match (which is important for strings) | ||
| return fa.exactAttribute().name(); | ||
| } | ||
| return attribute.name(); | ||
| } |
There was a problem hiding this comment.
Ternary operator ftw:
return (attribute instanceof FieldAttribute fa) ? fa.exactAttribute().name() : attribute.name()
Renamings and reformatting.
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
|
@elasticsearchmachine run elasticsearch-ci/part-2 |
This allows to push down those metadata attributes that can be pushed down. Out of the currently supported three, the only one pushed down is _index. This only supports wildcard and terms queries.
This allows to push down those metadata attributes that can be pushed down.
Out of the currently supported three, the only one pushed down is
_index. This only supports wildcard and terms queries.