Skip to content

Conversation

@nicpenning
Copy link
Contributor

  • Bug

Proposed commit message

See title / linked issue: #10178

  • WHAT: Clarify this integration as Microsoft Office 365
  • WHY: Improve user experience for finding integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

@nicpenning nicpenning marked this pull request as ready for review June 25, 2024 02:38
@nicpenning nicpenning requested a review from a team as a code owner June 25, 2024 02:38
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue's change proposal doesn't require that we change the path of the code. Let's keep that the same and just make the cosmetic changes that are required.

@nicpenning
Copy link
Contributor Author

The issue's change proposal doesn't require that we change the path of the code. Let's keep that the same and just make the cosmetic changes that are required.

Understood, I can do that. And hello again, 👋.

@nicpenning nicpenning closed this Jun 25, 2024
@nicpenning nicpenning reopened this Jun 25, 2024
@nicpenning
Copy link
Contributor Author

This was a doozy, but I think it will do. Let me know if you need me to blow this away and start over, thanks!

@efd6
Copy link
Contributor

efd6 commented Jun 25, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Jun 25, 2024

git rebase is your friend.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube
Copy link

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 4d81bd6 into elastic:main Jun 25, 2024
@elasticmachine
Copy link

Package o365 - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=o365

@andrewkroh andrewkroh added the Integration:o365 Microsoft Office 365 label Jul 22, 2024
@nicpenning nicpenning deleted the o365_QOL branch September 16, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:o365 Microsoft Office 365

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[o365] Integration Title/Short Description Change [Microsoft 365 --> Microsoft Office 365]

4 participants