Skip to content

[HAProxy] set event.module and event.dataset #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jun 29, 2021

What does this PR do?

This PR adds event.module and event.dataset to the integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@mtojek mtojek self-assigned this Jun 29, 2021
@mtojek mtojek requested a review from a team June 29, 2021 10:05
@mtojek mtojek added the Team:Integrations Label for the Integrations team label Jun 29, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1233 updated

  • Start Time: 2021-06-29T10:04:24.044+0000

  • Duration: 11 min 39 sec

  • Commit: c2a0d20

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

Trends 🧪

Image of Build Times

Image of Tests

@@ -15,7 +15,7 @@ categories:
- web
release: experimental
conditions:
kibana.version: "^7.13.0"
kibana.version: "^7.14.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed? Wouldn't be better if users of 7.13 can already benefit from this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agreed before not to release changes for older stacks if it isn't necessary. This way changes are added only the latest one.

@andresrc I hope that's ok?

Copy link
Member

@jsoriano jsoriano Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's continue like this if this is the current convention, but I think this artificially couples packages to versions of the stack, ideally packages should depend on the minor version of the stack that they require to work. Changes that don't affect compatibility with shouldn't need to update this.
This way newer packages could be used by users of older, but otherwise compatible, Kibana versions.

@mtojek mtojek merged commit 41548fa into elastic:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants