-
Notifications
You must be signed in to change notification settings - Fork 452
[google_workspace] Add calendar event type as a new data stream #13461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_workspace] Add calendar event type as a new data stream #13461
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
groups |
11904.76 | 9615.38 | -2289.38 (-19.23%) | 💔 |
saml |
10000 | 5988.02 | -4011.98 (-40.12%) | 💔 |
chrome |
2564.1 | 1733.1 | -831 (-32.41%) | 💔 |
context_aware_access |
5617.98 | 3968.25 | -1649.73 (-29.37%) | 💔 |
data_studio |
5524.86 | 4219.41 | -1305.45 (-23.63%) | 💔 |
drive |
7246.38 | 5780.35 | -1466.03 (-20.23%) | 💔 |
To see the full report comment with /test benchmark fullreport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the proposed commit message to say where/how the test case inputs were obtained.
packages/google_workspace/data_stream/calendar/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
...google_workspace/kibana/dashboard/google_workspace-0a2bcebc-a1ca-42b6-bb04-6206d8885eec.json
Outdated
Show resolved
Hide resolved
packages/google_workspace/data_stream/calendar/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/google_workspace/data_stream/calendar/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/google_workspace/data_stream/calendar/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
...ges/google_workspace/data_stream/calendar/_dev/test/pipeline/test-calendar.log-expected.json
Outdated
Show resolved
Hide resolved
Optimize ingest pipeline Improve dashboard navigation link user experience
Hi @efd6, Thanks for the review. I mostly agree with your suggestions and have applied the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This is looking good. Minor query only.
"domain": "bar.com", | ||
"email": "[email protected]", | ||
"id": "1", | ||
"name": "foo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been regenerated? The user.name
does not match the user.email
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dan!
"domain": "bar.com", | ||
"email": "[email protected]", | ||
"id": "1", | ||
"name": "foo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Package google_workspace - 2.36.0 containing this change is available at https://epr.elastic.co/package/google_workspace/2.36.0/ |
Proposed commit message
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Test Results:
Related issues
Screenshots