Skip to content

[google_workspace] Add calendar event type as a new data stream #13461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2025

Conversation

navnit-elastic
Copy link
Contributor

@navnit-elastic navnit-elastic commented Apr 8, 2025

Proposed commit message

google_workspace: add support for calendar event type as a new data stream

This adds support for the Calendar audit event type as a new data stream to
enhance the overall visibility of data in the Google Workspace integration.

This changes includes updating navigation links in to the relevant dashboards.

Sanitized test case inputs were obtained from live Google Workspace instance
using the Admin SDK for Reports API[1].

[1] https://developers.google.com/workspace/admin/reports/reference/rest

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Test Results:

--- Test results for package: google_workspace - START ---
╭──────────────────┬─────────────┬───────────┬──────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE          │ DATA STREAM │ TEST TYPE │ TEST NAME                                    │ RESULT │ TIME ELAPSED │
├──────────────────┼─────────────┼───────────┼──────────────────────────────────────────────┼────────┼──────────────┤
│ google_workspace │ calendar    │ pipeline  │ (ingest pipeline warnings test-calendar.log) │ PASS   │ 393.736522ms │
│ google_workspace │ calendar    │ pipeline  │ test-calendar.log                            │ PASS   │ 734.878125ms │
╰──────────────────┴─────────────┴───────────┴──────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: google_workspace - END   ---
Done

--- Test results for package: google_workspace - START ---
╭──────────────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE          │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├──────────────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ google_workspace │ calendar    │ system    │ default   │ PASS   │ 39.641710282s │
╰──────────────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: google_workspace - END   ---
Done

Related issues

Screenshots

google-workspace-calendar-configuration

google-workspace-calendar-screenshot

@navnit-elastic navnit-elastic added enhancement New feature or request Integration:google_workspace Google Workspace dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Apr 8, 2025
@navnit-elastic navnit-elastic self-assigned this Apr 8, 2025
@navnit-elastic navnit-elastic requested a review from a team as a code owner April 8, 2025 10:47
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Apr 8, 2025

🚀 Benchmarks report

Package google_workspace 👍(7) 💚(4) 💔(6)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
groups 11904.76 9615.38 -2289.38 (-19.23%) 💔
saml 10000 5988.02 -4011.98 (-40.12%) 💔
chrome 2564.1 1733.1 -831 (-32.41%) 💔
context_aware_access 5617.98 3968.25 -1649.73 (-29.37%) 💔
data_studio 5524.86 4219.41 -1305.45 (-23.63%) 💔
drive 7246.38 5780.35 -1466.03 (-20.23%) 💔

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the proposed commit message to say where/how the test case inputs were obtained.

Optimize ingest pipeline

Improve dashboard navigation link user experience
@navnit-elastic
Copy link
Contributor Author

Hi @efd6, Thanks for the review. I mostly agree with your suggestions and have applied the changes.
I am updating proposed message to include information about sample test logs and also updating the dashboard screenshots. Please have a look and let me know if anything needs to be changed.

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is looking good. Minor query only.

"domain": "bar.com",
"email": "[email protected]",
"id": "1",
"name": "foo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been regenerated? The user.name does not match the user.email.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan!

"domain": "bar.com",
"email": "[email protected]",
"id": "1",
"name": "foo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @navnit-elastic

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit a105504 into elastic:main Apr 10, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package google_workspace - 2.36.0 containing this change is available at https://epr.elastic.co/package/google_workspace/2.36.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:google_workspace Google Workspace Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Google Workspace]: Support calendar event type as a new data stream
3 participants