Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jul 6, 2025

Proposed commit message

o365: ensure that IDs are not rendered with e-notation

Due to JSON serialisation, numeric IDs may be rendered with e-notation
during flight. Ensure that this does not get fossilised into the
documents when they are converted to strings.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jul 6, 2025
@efd6 efd6 added Integration:o365 Microsoft Office 365 bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 6, 2025
Due to JSON serialisation, numeric IDs may be rendered with e-notation
during flight. Ensure that this does not get fossilised into the
documents when they are converted to strings.
@efd6 efd6 force-pushed the s6129-o365-numbers branch from 309e4b8 to af3aa4d Compare July 6, 2025 21:41
@elastic-sonarqube
Copy link

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review July 6, 2025 22:07
@efd6 efd6 requested a review from a team as a code owner July 6, 2025 22:07
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as is.

An alternative would be to have one script processor with a function that's run once for each field.

@efd6 efd6 merged commit 08eafa3 into elastic:main Jul 7, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package o365 - 2.18.5 containing this change is available at https://epr.elastic.co/package/o365/2.18.5/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants