Skip to content

Conversation

@chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Jul 16, 2025

Proposed commit message

[o365] Stricter enforcement of maximum age limits

In order to avoid requesting data more than 7 days old:

- When calculating the start of the allowed time range, use `now()` (a
  function that returns the current time) rather than `now` (which is
  the time the current CEL evaluation began), as the latter will become
  too old if a singe CEL evaluation runs for more than a few minutes.

- Make the `167h55m`  limit used throughout the CEL expression
  configurable, in the advanced settings, so that it can be shortened if
  necessary.

This integration's CEL expression is one that may run for a long time.
For each of a list of content types it will register a subscription,
list data and fetch data, and this has been observed to take many
minutes.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chrisberkhout chrisberkhout self-assigned this Jul 16, 2025
@chrisberkhout chrisberkhout requested a review from a team as a code owner July 16, 2025 14:03
@chrisberkhout chrisberkhout added bugfix Pull request that fixes a bug issue Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 16, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jul 16, 2025

🚀 Benchmarks report

Package o365 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 1672.24 1010.1 -662.14 (-39.6%) 💔

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits only

@chrisberkhout chrisberkhout requested a review from efd6 July 17, 2025 07:29
@chrisberkhout chrisberkhout enabled auto-merge (squash) July 17, 2025 07:29
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@elastic-sonarqube
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

@chrisberkhout chrisberkhout merged commit 486b5de into elastic:main Jul 17, 2025
8 checks passed
@elastic-vault-github-plugin-prod

Package o365 - 2.18.6 containing this change is available at https://epr.elastic.co/package/o365/2.18.6/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants