Filebeat O365 Package #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 5, 2020 11:37
andrewstucki
added
enhancement
|
Pinging @elastic/integrations (Team:Integrations) |
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build Succeeded
Expand to view the summary
Build stats
|
mtojek
approved these changes
Aug 6, 2020
Contributor
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
LGTM, although I'm not sure if you should present to the end user all configuration fields (show_user: true)
andrewkroh
added
Integration:o365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This converts the Microsoft Office 365 filebeat module to a package including inputs for both the Azure API and log file inputs.
Checklist
Screenshots