-
Notifications
You must be signed in to change notification settings - Fork 464
[azure logs] Update docs with details about event hub name recommendations #3209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌐 Coverage report
|
Hey @ravikesarwani, here's the first edit of the Azure Logs documentation to inform the users about what characters to use for the Event Hub name to maximize compatibility. I made some minor changes to the docs, but I want to know your perspective on how far we want to update the docs right now. The full details are in the files changed section, but I also added a screenshot with the rendering of the main README file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Elastic recommends using only letters, numbers, and the hyphen (-) character for Event Hub names to maximize compatibility. You can use existing Event Hubs having underscores (_) in the name, and the integration will adjust the settings when required" This is great but leaves users wanting to know more. I think its okay to expand this a little more and explain the reason "why".
Yeah, I was puzzled about telling users more, or keeping things high level. Let's expand it a little, what about:
|
4523ac8
to
357dabf
Compare
@ravikesarwani added a final rendering in the PR description: is there anything else you want to change in the Azure docs? |
Good from my side. |
Event hub names should avoid using underscores (_) if possible to maximize compatibility with dependant Azure resources (for example, the storage account name).
But the sample event and exported field will be available in each dataset (activitylogs, auditlogs, and so on).
What does this PR do?
Updates the Azure Logs documentation adding recommendations about the Event Hub name, and explaining how it is used by the integration when it contains underscores (_) characters.
Checklist
I have verified that all data streams collect metrics or logs.changelog.yml
file.I have verified that Kibana version constraints are current according to guidelines.Author's Checklist
How to test this PR locally
Related issues
Screenshots