Skip to content

[azure logs] Update docs with details about event hub name recommendations #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 11, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Apr 27, 2022

What does this PR do?

Updates the Azure Logs documentation adding recommendations about the Event Hub name, and explaining how it is used by the integration when it contains underscores (_) characters.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

CleanShot 2022-05-05 at 17 07 05@2x

@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-11T10:26:55.014+0000

  • Duration: 13 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 86
Skipped 0
Total 86

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 78.571% (11/14) 👎 -17.77
Classes 78.571% (11/14) 👎 -17.77
Methods 76.724% (89/116) 👎 -12.16
Lines 80.46% (1540/1914) 👎 -9.643
Conditionals 100.0% (0/0) 💚

@zmoog
Copy link
Contributor Author

zmoog commented Apr 27, 2022

Hey @ravikesarwani, here's the first edit of the Azure Logs documentation to inform the users about what characters to use for the Event Hub name to maximize compatibility.

I made some minor changes to the docs, but I want to know your perspective on how far we want to update the docs right now.

The full details are in the files changed section, but I also added a screenshot with the rendering of the main README file.

CleanShot 2022-04-27 at 16 43 55@2x

Copy link

@ravikesarwani ravikesarwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Elastic recommends using only letters, numbers, and the hyphen (-) character for Event Hub names to maximize compatibility. You can use existing Event Hubs having underscores (_) in the name, and the integration will adjust the settings when required" This is great but leaves users wanting to know more. I think its okay to expand this a little more and explain the reason "why".

@zmoog
Copy link
Contributor Author

zmoog commented Apr 27, 2022

"Elastic recommends using only letters, numbers, and the hyphen (-) character for Event Hub names to maximize compatibility. You can use existing Event Hubs having underscores (_) in the name, and the integration will adjust the settings when required" This is great but leaves users wanting to know more. I think its okay to expand this a little more and explain the reason "why".

Yeah, I was puzzled about telling users more, or keeping things high level.

Let's expand it a little, what about:

It is a fully managed, real-time data ingestion service. Elastic recommends using only letters, numbers, and the hyphen (-) character for Event Hub names to maximize compatibility. You can use existing Event Hubs having underscores (_) in the Event Hub name. The integration will replace underscores with hyphens (-) when it uses the Event Hub name to create dependent Azure resources behind the scenes (e.g., the storage account container to store Event Hub consumer offsets).

@andrewkroh andrewkroh added the Integration:azure Azure Logs label Apr 27, 2022
@zmoog zmoog self-assigned this Apr 28, 2022
@zmoog zmoog force-pushed the azure-update-docs branch from 4523ac8 to 357dabf Compare April 28, 2022 11:36
@zmoog zmoog marked this pull request as ready for review April 28, 2022 11:43
@zmoog zmoog requested a review from a team as a code owner April 28, 2022 11:43
@zmoog
Copy link
Contributor Author

zmoog commented Apr 28, 2022

@ravikesarwani added a final rendering in the PR description: is there anything else you want to change in the Azure docs?

@ravikesarwani
Copy link

Good from my side.

@zmoog zmoog force-pushed the azure-update-docs branch from 357dabf to 3a11541 Compare May 2, 2022 09:34
@zmoog zmoog force-pushed the azure-update-docs branch from 3a11541 to 7e986e5 Compare May 5, 2022 15:05
zmoog added 4 commits May 11, 2022 12:25
Event hub names should avoid using underscores (_) if possible to
maximize compatibility with dependant Azure resources (for example,
the storage account name).
But the sample event and exported field will be available in each
dataset (activitylogs, auditlogs, and so on).
@zmoog zmoog force-pushed the azure-update-docs branch from 7e986e5 to 847676d Compare May 11, 2022 10:26
@zmoog zmoog merged commit 1f7414e into elastic:main May 11, 2022
@zmoog zmoog deleted the azure-update-docs branch May 11, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants