Skip to content

haproxy_apache_trafeik_2617_dashboard: migrate tile_map->map #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ishleenk17
Copy link
Member

@ishleenk17 ishleenk17 commented Jun 1, 2022

  • Enhancement

What does this PR do?

This PR replaces the tile_map object with map in haproxy, apache, traefik logs dashboard

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Load the newly created dashboard and we should see map as the object

Screenshots

Below screenshot shows map object updated in HAproxy

Screenshot 2022-06-02 at 2 56 01 PM

Below screenshot shows map object updated in Apache

Screenshot 2022-06-02 at 11 10 42 AM

Below screenshot shows map object updated in Traefik

Screenshot 2022-06-02 at 3 06 48 PM

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-02T09:40:51.454+0000

  • Duration: 18 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 106
Skipped 0
Total 106

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 75.0% (6/8)
Classes 75.0% (6/8)
Methods 83.333% (70/84)
Lines 82.759% (552/667)
Conditionals 100.0% (0/0) 💚

@ishleenk17 ishleenk17 changed the title haproxy_2617_dashboard:migrate tile_map->map haproxy_apache__2617_dashboard: migrate tile_map->map Jun 2, 2022
@ishleenk17 ishleenk17 changed the title haproxy_apache__2617_dashboard: migrate tile_map->map haproxy_apache_2617_dashboard: migrate tile_map->map Jun 2, 2022
@ishleenk17 ishleenk17 marked this pull request as ready for review June 2, 2022 09:55
@ishleenk17 ishleenk17 requested a review from a team as a code owner June 2, 2022 09:55
@ishleenk17 ishleenk17 requested a review from andrewkroh June 2, 2022 09:55
@ishleenk17 ishleenk17 changed the title haproxy_apache_2617_dashboard: migrate tile_map->map haproxy_apache_trafeik_2617_dashboard: migrate tile_map->map Jun 2, 2022
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we update the dashboard images in /img directory ? I still see the Tiles map representation.

@ishleenk17
Copy link
Member Author

Did we update the dashboard images in /img directory ? I still see the Tiles map representation.

We are not having the complete dashboard repopulated for these integrations in this change. Just the tile map change.
Hence, I don't think we can change the screenshot, as that needs all the fields populated.

The same approach has been followed by other teams for changes under this issue. So, should be fine.

@muthu-mps muthu-mps self-requested a review June 3, 2022 04:42
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishleenk17 ishleenk17 merged commit 2896f2d into elastic:main Jun 3, 2022
@ishleenk17 ishleenk17 deleted the haproxy_apache_system_trafeik_2617 branch February 7, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tile_map objects to map objects
3 participants