Skip to content

[Cloud Posture] Added time filters to integration's index-pattern #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2022
Merged

[Cloud Posture] Added time filters to integration's index-pattern #3709

merged 3 commits into from
Jul 14, 2022

Conversation

kfirpeled
Copy link
Contributor

@kfirpeled kfirpeled commented Jul 14, 2022 •
edited
Loading

What does this PR do?

We've added timeFieldName to integration's index-patterns

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Install the newer version on top of an existing one or do a fresh install.
Then, go to the discover page and fetch data from the findings data views.
You should be able to see time range filters

Related issues

Screenshots

Screen Shot 2022-07-14 at 13 26 57

@kfirpeled kfirpeled added enhancement New feature or request v8.4.0 Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Jul 14, 2022
@kfirpeled kfirpeled requested a review from orouz July 14, 2022 10:28
@kfirpeled kfirpeled marked this pull request as ready for review July 14, 2022 10:28
@kfirpeled kfirpeled requested a review from a team as a code owner July 14, 2022 10:28
@kfirpeled kfirpeled mentioned this pull request Jul 14, 2022
Merged
5 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 14, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T10:31:19.294+0000

  • Duration: 16 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.093
Classes 100.0% (0/0) 💚 3.093
Methods 33.333% (1/3) 👎 -55.724
Lines 100.0% (0/0) 💚 9.807
Conditionals 100.0% (0/0) 💚

orouz
orouz approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@orouz orouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfirpeled kfirpeled merged commit d5a04f9 into elastic:main Jul 14, 2022
@kfirpeled kfirpeled deleted the cspm/findings-data-view-timefield branch July 14, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orouz orouz orouz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Kibana / Discover / Findings - Missing time filters
3 participants
@kfirpeled @elasticmachine @orouz