Skip to content

[cisco_ise] Typo: target_fields are reversed #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2022
Merged

[cisco_ise] Typo: target_fields are reversed #3830

merged 3 commits into from
Oct 31, 2022

Conversation

Metropolix
Copy link
Contributor

@Metropolix Metropolix commented Jul 25, 2022 •
edited by andrewkroh
Loading

What does this PR do?

Fix handling of IdentityPolicyMatchedRule and IdentitySelectionMatchedRule. The target_field for the two related processors has the names swapped.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@Metropolix Metropolix requested a review from a team as a code owner July 25, 2022 20:17
@cla-checker-service
Copy link

cla-checker-service bot commented Jul 25, 2022 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link

elasticmachine commented Jul 25, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-31T20:16:25.007+0000

  • Duration: 18 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 90
Skipped 0
Total 90

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@Metropolix
Copy link
Contributor Author

Metropolix commented Jul 26, 2022 •
edited
Loading

/test

@andrewkroh andrewkroh changed the title Typo: target_fields are reversed [cisco_ise] Typo: target_fields are reversed Jul 26, 2022
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_ise Cisco ISE labels Jul 26, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
Copy link
Member

@Metropolix thanks for the fix. I see your GH name in the CLA database, but the email address in the commit (see https://github.com/elastic/integrations/pull/3830.patch) doesn't match up. Can you please amend the commit to adjust author to match the email used to sign the CLA.

@andrewkroh andrewkroh added the needs CLA User must sign the Elastic Contributor License before review. label Aug 2, 2022
@andrewkroh andrewkroh marked this pull request as draft August 2, 2022 14:53
@botelastic
Copy link

botelastic bot commented Oct 12, 2022

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 12, 2022
Titine1999 and others added 3 commits October 31, 2022 15:53
@Titine1999 @andrewkroh
Typo: target_fields are reversed
05c9be4
@andrewkroh
Merge remote-tracking branch 'elastic/main' into Metropolix/main
1f4a51d
@andrewkroh
Add changelog
6c73627 
[git-generate]
cd packages/cisco_ise
elastic-package changelog add --description "Fix handling of IdentityPolicyMatchedRule and IdentitySelectionMatchedRule." --link elastic#3830 --type bugfix --next patch
@botelastic botelastic bot removed the Stalled label Oct 31, 2022
@andrewkroh andrewkroh removed the needs CLA User must sign the Elastic Contributor License before review. label Oct 31, 2022
@andrewkroh andrewkroh marked this pull request as ready for review October 31, 2022 20:04
@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (17/17) 💚 2.215
Classes 100.0% (17/17) 💚 2.215
Methods 100.0% (181/181) 💚 9.589
Lines 99.835% (3019/3024) 👍 8.276
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh merged commit e17e0fd into elastic:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:cisco_ise Cisco ISE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Metropolix @elasticmachine @andrewkroh @Titine1999