Update ECS to 8.4.0 Part 4 #3865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leehinman
commented
Jul 27, 2022
leehinman
commented
- cylance
- f5
- fim
- fireeye
- fortinet
- gcp
- gcp_pubsub
- github
- google_workspace
- hashicorp_vault
leehinman
added
enhancement
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
leehinman
force-pushed
the
ecs_8.4_part_4
branch
from
30f26ed to
28117cd
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
kcreddy
requested changes
Jul 28, 2022
packages/fim/data_stream/event/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/gcp/data_stream/vpcflow/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
| @@ -1,6 +1,6 @@ | |||
| name: gcp_pubsub | |||
| title: Custom Google Pub/Sub Logs | |||
| version: "1.1.0" | |||
| version: "1.2.0" | |||
There was a problem hiding this comment.
Probably generic datastream pipeline inside gcp_pub needs ECS version update
packages/hashicorp_vault/data_stream/metrics/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
|
I don't think @elastic/obs-cloud-monitoring should be listed as a code owner here, all of these integrations are owned by @elastic/security-external-integrations? EDIT: Never mind I suppose, CODEOWNERS lists both teams, but Github is only lists @elastic/obs-cloud-monitoring as the codeowner for the PR. |
kcreddy
approved these changes
Jul 29, 2022
ECS version updated to 8.4.0
ECS version updated to 8.4.0
ECS version updated to 8.4.0
ECS version updated to 8.4.0
ECS version updated to 8.4.0
ECS version updated to 8.4.0
ECS version updated to 8.4.0
ECS version updated to 8.4.0
ECS version updated to 8.4.0
ECS version updated to 8.4.0
leehinman
force-pushed
the
ecs_8.4_part_4
branch
from
28117cd to
420ec22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.