Skip to content

citrix_waf,cloudflare,cyberark_pta,cylance,darktrace: remove duplicated fields #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 6, 2022

What does this PR do?

This removes duplicated field definitions from a set of packages identified in #4398.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cylance CylanceProtect Logs (Deprecated) Integration:cloudflare Cloudflare (Community supported) Integration:cyberark_pta Cyberark Privileged Threat Analytics Integration:citrix_waf Citrix Web App Firewall labels Oct 6, 2022
@efd6 efd6 self-assigned this Oct 6, 2022
@efd6 efd6 force-pushed the 4398-citric-darktrace branch from eba5645 to f9ad083 Compare October 6, 2022 06:15
@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T03:25:12.824+0000

  • Duration: 26 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 150
Skipped 0
Total 150

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

🚀 Benchmarks report

Package citrix_waf 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1814.88 1213.59 -601.29 (-33.13%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (11/11) 💚 2.496
Classes 100.0% (11/11) 💚 2.496
Methods 98.347% (119/121) 👍 8.013
Lines 95.445% (3353/3513) 👍 3.815
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review October 6, 2022 06:41
@efd6 efd6 requested a review from a team as a code owner October 6, 2022 06:41
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 force-pushed the 4398-citric-darktrace branch from f9ad083 to a2afa93 Compare October 11, 2022 03:24
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 0a4b6b1 into elastic:main Oct 11, 2022
@efd6 efd6 deleted the 4398-citric-darktrace branch February 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:citrix_waf Citrix Web App Firewall Integration:cloudflare Cloudflare (Community supported) Integration:cyberark_pta Cyberark Privileged Threat Analytics Integration:cylance CylanceProtect Logs (Deprecated)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants