Skip to content

[Mimecast] Fix template config and verify cursor test #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Feb 23, 2023

What does this PR do?

This PR fixes the template config in all data_streams in mimecast integration and also verifies assert.hit_count for cursor test.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package stack down && elastic-package build && elastic-package stack up -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test

Related issues

@elasticmachine
Copy link

elasticmachine commented Feb 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-23T15:39:23.291+0000

  • Duration: 20 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 95.726% (112/117) 👍 3.302
Lines 88.569% (1232/1391) 👎 -7.182
Conditionals 100.0% (0/0) 💚

@bhapas bhapas self-assigned this Feb 23, 2023
@bhapas bhapas changed the title initial commit [Mimecast] Fix template config and verify cursor test Feb 23, 2023
@bhapas bhapas added the Integration:mimecast Mimecast (Partner supported) label Feb 23, 2023
@bhapas bhapas marked this pull request as ready for review February 23, 2023 15:59
@bhapas bhapas requested a review from a team as a code owner February 23, 2023 15:59
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that there are duplication issues in the test data. I'm dealing with that in #5376, so I'll fix up the newly added events in that PR after this is merged.

@bhapas bhapas merged commit cb0e9c6 into elastic:main Feb 24, 2023
@bhapas bhapas deleted the mimecast-config branch February 24, 2023 06:51
@elasticmachine
Copy link

Package mimecast - 1.6.2 containing this change is available at https://epr.elastic.co/search?package=mimecast

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@bn-jmynsberge
Copy link

bn-jmynsberge commented Mar 27, 2024

I know this issue is closed, but I'm still seeing this error on 1.6.3:

error processing response: template: :1:16: executing "" at <.last_response.body.meta.pagination.next>: map has no entry for key "next"
error processing response: template: :1:27: executing "" at <.last_response.body.meta.pagination>: map has no entry for key "pagination"

It seems like this fix was only applied to the audit logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:mimecast Mimecast (Partner supported)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants