Skip to content

[np]*: ensure event.kind is correctly set for pipeline errors #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

[np]*: ensure event.kind is correctly set for pipeline errors #6662

merged 1 commit into from
Jun 22, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 22, 2023 •
edited
Loading

What does this PR do?

Modify netscout, panw, panw_cortex_xdr, pfsense, ping_one, proofpoint_tap and pulse_connect_secure to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 22, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-22T03:04:37.655+0000

  • Duration: 19 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 153
Skipped 0
Total 153

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6 efd6 mentioned this pull request Jun 22, 2023
Closed
@elasticmachine
Copy link

elasticmachine commented Jun 22, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (12/12) 💚
Files 100.0% (34/34) 💚 77.778
Classes 100.0% (34/34) 💚 77.778
Methods 98.932% (278/281) 👍 65.599
Lines 95.416% (8306/8705) 👍 72.41
Conditionals 100.0% (0/0) 💚

@efd6
[np]*: ensure event.kind is correctly set for pipeline errors
69f3e57 
netscout, panw, panw_cortex_xdr, pfsense, ping_one, proofpoint_tap,
pulse_connect_secure
@efd6 efd6 marked this pull request as ready for review June 22, 2023 03:44
@efd6 efd6 requested a review from a team as a code owner June 22, 2023 03:44
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

bhapas
bhapas approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 41894d5 into elastic:main Jun 22, 2023
@elasticmachine
Copy link

Package netscout - 0.16.0 containing this change is available at https://epr.elastic.co/search?package=netscout

@elasticmachine
Copy link

Package netskope - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=netskope

@elasticmachine
Copy link

Package panw - 3.12.0 containing this change is available at https://epr.elastic.co/search?package=panw

@elasticmachine
Copy link

Package panw_cortex_xdr - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=panw_cortex_xdr

@elasticmachine
Copy link

Package pfsense - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=pfsense

@elasticmachine
Copy link

Package ping_one - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=ping_one

@elasticmachine
Copy link

Package proofpoint_tap - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=proofpoint_tap

@elasticmachine
Copy link

Package pulse_connect_secure - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=pulse_connect_secure

@andrewkroh andrewkroh added Integration:netscout Arbor Peakflow SP Logs (Deprecated) Integration:netskope Netskope Integration:panw Palo Alto Next-Gen Firewall Integration:panw_cortex_xdr Palo Alto Cortex XDR Integration:pfsense pfSense (Community supported) Integration:ping_one PingOne Integration:proofpoint_tap Proofpoint TAP Integration:pulse_connect_secure Pulse Connect Secure (Community supported) labels Jul 22, 2024
@efd6 efd6 deleted the 6582-np branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:netscout Arbor Peakflow SP Logs (Deprecated) Integration:netskope Netskope Integration:panw_cortex_xdr Palo Alto Cortex XDR Integration:panw Palo Alto Next-Gen Firewall Integration:pfsense pfSense (Community supported) Integration:ping_one PingOne Integration:proofpoint_tap Proofpoint TAP Integration:pulse_connect_secure Pulse Connect Secure (Community supported)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @elasticmachine @bhapas @andrewkroh