-
Notifications
You must be signed in to change notification settings - Fork 469
[HAProxy] Add timezone offset support #6767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌐 Coverage report
|
@P1llus : I see this is a timezone input configuration which we take from users in multiple Integrations. I suppose we can make it as a default configuration input for Integrations having logs without timezone. |
@ishleenk17 that is correct. I left the default value in the manifest.yml empty, because add_locale already existed, to prevent any changing behavior for existing users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit in the description, else looks good!
Package haproxy - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=haproxy |
What does this PR do?
HAproxy mostly does not log with a timezone by default, and we hardcode add_local after any custom processors, so its not possible to override the local timezone.
The PR adds the common timezone offset which we use in other integration + changes the order of add_locale to be before custom processors.
Checklist
changelog.yml
file.