Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Aug 28, 2023

What does this PR do?

The default limit in the Filebeat input is 1MiB which is too small for some responses, resulting in loss of visibility in debugging issues in the integration, so increase to 5MiB.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:o365 Microsoft Office 365 labels Aug 28, 2023
@efd6 efd6 self-assigned this Aug 28, 2023
The default limit in the Filebeat input is 1MiB which is too small for
some responses, resulting in loss of visibility in debugging issues in
the integration, so increase to 5MiB.
@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-28T22:50:26.588+0000

  • Duration: 15 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (16/16) 💚 25.0
Lines 80.994% (733/905) 👎 -19.006
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review August 28, 2023 23:05
@efd6 efd6 requested a review from a team as a code owner August 28, 2023 23:05
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 requested a review from kcreddy August 28, 2023 23:06
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 939c278 into elastic:main Aug 29, 2023
@elasticmachine
Copy link

Package o365 - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=o365

@efd6 efd6 deleted the o365-maxsize branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:o365 Microsoft Office 365

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants