Skip to content

Set sensitive values as secret - Part 3 #9128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2024
Merged

Set sensitive values as secret - Part 3 #9128

merged 3 commits into from
Feb 23, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Feb 12, 2024 •
edited
Loading

Proposed commit message

  • Set sensitive values as secret in integrations.
  • Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks.
  • Certain packages required fixes to mappings (due to missing or incorrect mappings).
  • Certain packages were not able to go to package-spec 3.0.2 due issues with dynamic mappings. These have been held back at 3.0.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • Relates elastic/security-team#7388

@taylor-swanson taylor-swanson self-assigned this Feb 12, 2024
@taylor-swanson taylor-swanson added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Feb 12, 2024
@elasticmachine
Copy link

elasticmachine commented Feb 12, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson taylor-swanson marked this pull request as ready for review February 12, 2024 17:31
@taylor-swanson taylor-swanson requested a review from a team as a code owner February 12, 2024 17:31
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

packages/o365/data_stream/audit/fields/fields.yml Outdated
type: keyword
type: long
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actor.Type and Target.Type are both mapped to same type. Maybe we could make it both integer or long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll actually drop in a convert processor here. Dan mentioned this here and I think it's applicable in this case as well. In general, even though it is technically a number, what we really want is it indexed as is a keyword.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

kcreddy
kcreddy approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@taylor-swanson taylor-swanson merged commit 61f1051 into elastic:main Feb 23, 2024
@taylor-swanson taylor-swanson deleted the feature/secret-values-svc-3 branch February 23, 2024 14:26
@elasticmachine
Copy link

Package o365 - 2.3.0 containing this change is available at https://epr.elastic.co/search?package=o365

@elasticmachine
Copy link

Package okta - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=okta

@elasticmachine
Copy link

Package panw_cortex_xdr - 1.25.0 containing this change is available at https://epr.elastic.co/search?package=panw_cortex_xdr

@elasticmachine
Copy link

Package ping_one - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=ping_one

@elasticmachine
Copy link

Package prisma_cloud - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=prisma_cloud

@elasticmachine
Copy link

Package proofpoint_tap - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=proofpoint_tap

@elasticmachine
Copy link

Package qualys_vmdr - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=qualys_vmdr

@elasticmachine
Copy link

Package rapid7_insightvm - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=rapid7_insightvm

@elasticmachine
Copy link

Package sentinel_one - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=sentinel_one

@elasticmachine
Copy link

Package sentinel_one_cloud_funnel - 0.11.0 containing this change is available at https://epr.elastic.co/search?package=sentinel_one_cloud_funnel

@elasticmachine
Copy link

Package slack - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=slack

@elasticmachine
Copy link

Package snyk - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=snyk

@elasticmachine
Copy link

Package sophos_central - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=sophos_central

@elasticmachine
Copy link

Package symantec_edr_cloud - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=symantec_edr_cloud

@elasticmachine
Copy link

Package tanium - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=tanium

@elasticmachine
Copy link

Package tenable_io - 2.9.0 containing this change is available at https://epr.elastic.co/search?package=tenable_io

@elasticmachine
Copy link

Package tenable_sc - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=tenable_sc

gizas pushed a commit that referenced this pull request Mar 13, 2024
@taylor-swanson @gizas
Set sensitive values as secret - Part 3 (#9128)
cdf0fbc 
- Set sensitive values as secret in integrations.
- Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks.
- Certain packages required fixes to mappings (due to missing or incorrect mappings).
- Certain packages were not able to go to package-spec 3.0.2 due to issues with dynamic mappings. These have been held back at 3.0.0.
@andrewkroh andrewkroh added Integration:proofpoint_tap Proofpoint TAP Integration:symantec_edr_cloud Symantec EDR Cloud (Deprecated) [Integration not found in source] Integration:tenable_io Tenable Vulnerability Management Integration:rapid7_insightvm Rapid7 InsightVM Integration:sentinel_one_cloud_funnel SentinelOne Cloud Funnel Integration:snyk Snyk Integration:sophos_central Sophos Central Integration:tanium Tanium Integration:okta Okta Integration:prisma_cloud Palo Alto Prisma Cloud Integration:qualys_vmdr Qualys VMDR Integration:tenable_sc Tenable Security Center Integration:sentinel_one SentinelOne Integration:slack Slack Logs (Community supported) Integration:o365 Microsoft Office 365 Integration:panw_cortex_xdr Palo Alto Cortex XDR Integration:ping_one PingOne labels Jul 22, 2024
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@taylor-swanson @gizas
Set sensitive values as secret - Part 3 (#9128)
0c5233f 
- Set sensitive values as secret in integrations.
- Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks.
- Certain packages required fixes to mappings (due to missing or incorrect mappings).
- Certain packages were not able to go to package-spec 3.0.2 due to issues with dynamic mappings. These have been held back at 3.0.0.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@taylor-swanson @gizas
Set sensitive values as secret - Part 3 (#9128)
ea53e73 
- Set sensitive values as secret in integrations.
- Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks.
- Certain packages required fixes to mappings (due to missing or incorrect mappings).
- Certain packages were not able to go to package-spec 3.0.2 due to issues with dynamic mappings. These have been held back at 3.0.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Integration:o365 Microsoft Office 365 Integration:okta Okta Integration:panw_cortex_xdr Palo Alto Cortex XDR Integration:ping_one PingOne Integration:prisma_cloud Palo Alto Prisma Cloud Integration:proofpoint_tap Proofpoint TAP Integration:qualys_vmdr Qualys VMDR Integration:rapid7_insightvm Rapid7 InsightVM Integration:sentinel_one_cloud_funnel SentinelOne Cloud Funnel Integration:sentinel_one SentinelOne Integration:slack Slack Logs (Community supported) Integration:snyk Snyk Integration:sophos_central Sophos Central Integration:symantec_edr_cloud Symantec EDR Cloud (Deprecated) [Integration not found in source] Integration:tanium Tanium Integration:tenable_io Tenable Vulnerability Management Integration:tenable_sc Tenable Security Center Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taylor-swanson @elasticmachine @kcreddy @andrewkroh