Disable secrets for packages with older stack versions due to errors. #9279
Conversation
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @ritalwar |
|
100.0% Coverage on New Code
0.0% Duplication on New Code
| @@ -16,7 +16,7 @@ streams: | |||
| - name: client_secret | |||
| type: password | |||
| title: Client Secret | |||
| secret: true | |||
| secret: false | |||
There was a problem hiding this comment.
I hope the removal of secrets and setting secrets:false doesn't have any difference.
There was a problem hiding this comment.
Actually, that's the correct approach because we're using package format 3.0.2. If we don't set secret to false, we'll get build errors.
There was a problem hiding this comment.
@ritalwar I tried loading the integrations with default configs in 8.11.0 and 8.10.1 versions and I didn't face any errors loading the packages present in this PR. LGTM for the changes !!
cc:- @lalit-satapathy
|
LGTM for reverting the secrets for older stack version. |
|
Package activemq - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=activemq |
|
Package apache_tomcat - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat |
|
Package azure_app_service - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=azure_app_service |
|
Package azure_billing - 1.4.2 containing this change is available at https://epr.elastic.co/search?package=azure_billing |
|
Package azure_functions - 0.3.1 containing this change is available at https://epr.elastic.co/search?package=azure_functions |
|
Package cassandra - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=cassandra |
|
Package ceph - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=ceph |
|
Package citrix_adc - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=citrix_adc |
|
Package cockroachdb - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=cockroachdb |
|
Package golang - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=golang |
|
Package kafka - 1.12.1 containing this change is available at https://epr.elastic.co/search?package=kafka |
|
Package kafka_log - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=kafka_log |
|
Package mysql - 1.18.2 containing this change is available at https://epr.elastic.co/search?package=mysql |
|
Package nginx - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=nginx |
|
Package oracle_weblogic - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic |
|
Package rabbitmq - 1.12.1 containing this change is available at https://epr.elastic.co/search?package=rabbitmq |
|
Package salesforce - 0.13.1 containing this change is available at https://epr.elastic.co/search?package=salesforce |
|
Package spring_boot - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=spring_boot |
|
Package websphere_application_server - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server |
…#9279) * Disable secrets for packages with older stack versions due to errors.
andrewkroh
added
Integration:golang
…#9279) * Disable secrets for packages with older stack versions due to errors.
…#9279) * Disable secrets for packages with older stack versions due to errors.
Proposed commit message
This PR disables the secrets for packages on versions below 8.10.0 due to errors. More details in comment section here.
Checklist
changelog.ymlfile.Related issues