Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Apr 3, 2024

Proposed commit message

In some cases, this field may be a string. This results in a mapping failure. So in cases where the field is a string, conditionally parse out the JSON.


See caveat here.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:o365 Microsoft Office 365 bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Apr 3, 2024
@efd6 efd6 self-assigned this Apr 3, 2024
@efd6 efd6 force-pushed the b37800-o365 branch 2 times, most recently from c80200a to 321a2ae Compare April 3, 2024 01:24
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review April 3, 2024 02:29
@efd6 efd6 requested a review from a team as a code owner April 3, 2024 02:29
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In some cases, this field may be a string. This results in a mapping
failure. So in cases where the field is a string, conditionally parse
out the JSON.
@efd6
Copy link
Contributor Author

efd6 commented Apr 4, 2024

Waiting on input from reporter for answer to question (here and here) before merging.

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #10040 succeeded 321a2aebf15495756d831e8b23c471a1ad7d74ae
  • 💔 Build #10039 failed c80200a3aacbb233f7b0076d937370ab9b2a1145

cc @efd6

@elastic-sonarqube
Copy link

@efd6 efd6 merged commit 6f946f9 into elastic:main Apr 6, 2024
@elasticmachine
Copy link

Package o365 - 2.3.2 containing this change is available at https://epr.elastic.co/search?package=o365

@efd6 efd6 deleted the b37800-o365 branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants