Skip to content

Add tags and processors on GCP Compute, Firestore, PostgreSQL #9508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2024
Merged

Add tags and processors on GCP Compute, Firestore, PostgreSQL #9508

merged 1 commit into from
Jun 26, 2024

Conversation

Lucas-Feat
Copy link
Contributor

@Lucas-Feat Lucas-Feat commented Apr 3, 2024 •
edited
Loading

Proposed commit message

Add custom processors and tags to gcp Compute, Firestore and PostgreSQL integrations

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@Lucas-Feat Lucas-Feat requested review from a team as code owners April 3, 2024 13:26
@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Apr 3, 2024 •
edited
Loading

💚 CLA has been signed

@Lucas-Feat Lucas-Feat force-pushed the feat/gcp-processors branch 2 times, most recently from eb50814 to 27f261b Compare April 3, 2024 13:34
@Lucas-Feat
Copy link
Contributor Author

Do we have to reopen a new PR after we sign the Contributor Agreement ?

Thkx

@ishleenk17
Copy link
Member

Do we have to reopen a new PR after we sign the Contributor Agreement ?

Thkx

No, the same one should be fine

ali786XI
ali786XI suggested changes Apr 15, 2024
View reviewed changes
@ali786XI
Copy link
Contributor

ali786XI commented Apr 15, 2024 •
edited
Loading

@Lucas-Feat Can you also update the same at rest places as per above suggestions :)
Also please sign the contributor agreement else the CI won't be green

@Lucas-Feat Lucas-Feat force-pushed the feat/gcp-processors branch from 35dae2f to 8d696ef Compare April 15, 2024 14:01
@Lucas-Feat
Copy link
Contributor Author

@Lucas-Feat Can you also update the same at rest places as per above suggestions :) Also please sign the contributor agreement else the CI won't be green

I signed it twice, i don't know what i am doing wrong.

@Lucas-Feat Lucas-Feat force-pushed the feat/gcp-processors branch from 8d696ef to 45a24eb Compare May 14, 2024 13:20
@Lucas-Feat Lucas-Feat force-pushed the feat/gcp-processors branch from 45a24eb to b24f409 Compare May 29, 2024 13:01
@RJiraya
Copy link

RJiraya commented May 29, 2024

Hello, what's missing to merge this ? Thanks !

@Lucas-Feat Lucas-Feat requested a review from ali786XI May 29, 2024 13:03
@Lucas-Feat Lucas-Feat force-pushed the feat/gcp-processors branch from b24f409 to 577265c Compare May 29, 2024 13:21
@ali786XI
Copy link
Contributor

/test

ali786XI
ali786XI approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RJiraya
Copy link

RJiraya commented Jun 12, 2024

Hello, what's the next step to merge, and when it can be available ? Thank's !

ishleenk17
ishleenk17 reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just one nit.

@Lucas-Feat Lucas-Feat force-pushed the feat/gcp-processors branch from 577265c to 102fd36 Compare June 12, 2024 13:43
@RJiraya
Copy link

RJiraya commented Jun 19, 2024

Hello, is it good now ?

@ali786XI
Copy link
Contributor

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #12071 succeeded 577265cec01e2f87e9216f8fc10cf631eeab770f

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@RJiraya
Copy link

RJiraya commented Jun 24, 2024

any update ?

ishleenk17
ishleenk17 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ShourieG
ShourieG approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ali786XI ali786XI merged commit 44fb7a6 into elastic:main Jun 26, 2024
5 checks passed
@elasticmachine
Copy link

Package gcp - 2.34.0 containing this change is available at https://epr.elastic.co/search?package=gcp

@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Jul 22, 2024
@ali786XI ali786XI mentioned this pull request Jul 27, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@ShourieG ShourieG ShourieG approved these changes

@ali786XI ali786XI ali786XI approved these changes

Assignees
No one assigned
Labels
Integration:gcp Google Cloud Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Lucas-Feat @ishleenk17 @ali786XI @RJiraya @elasticmachine @MichaelKatsoulis @ShourieG @andrewkroh