Add option for JVM to dump its heap on OutOfMemory #4205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
OOOPSS @suyograo maybe adding this to windows too? https://github.com/elastic/logstash/blob/master/bin/setup.bat |
|
Nevermind last comment, I checked an old version of the file. Windows seems to support that for some time. |
|
Slow start today ☕ ☕ ☕ ☕ https://github.com/elastic/logstash/blob/master/bin/setup.bat#L51 <- we should enable that line by default too ? |
|
@ph ping. I chnaged the win file path, because |
| @@ -48,7 +48,7 @@ REM Causes the JVM to dump its heap on OutOfMemory. | |||
| set JAVA_OPTS=%JAVA_OPTS% -XX:+HeapDumpOnOutOfMemoryError | |||
| REM The path to the heap dump location, note directory must exists and have enough | |||
| REM space for a full heap dump. | |||
| REM JAVA_OPTS=%JAVA_OPTS% -XX:HeapDumpPath="$LS_HOME/logs/heapdump.hprof" | |||
| REM JAVA_OPTS=%JAVA_OPTS% -XX:HeapDumpPath="$LS_HOME/heapdump.hprof" | |||
|
LGTM, happy heap heap heap hurray dump! |
|
Merged sucessfully into master 2.1 2.x! |
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
suyograo
added a commit
that referenced
this pull request
Nov 17, 2015
|
how do i disable this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4192