-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Use CI skip on release-marking PRs #23165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How does [ci skip] work, anyway? |
Its some kind of circle-ci or github actions specific string that causes the steps not to run. I don't know that it also makes the "required" steps magically not required? |
I think |
Aha ok interesting it's not supported for fork PRs, that's why it's not working here. |
But that's a good point about branch protections; my guess would be that the PR won't be blocked by CI that isn't run; just by CI that fails. |
I'm not sure the circleci <-> github integration is smart enough to do that.. but I hope so. |
Should we try this out and see what happens then? Do you want to LGTM? |
We can always land these change by force I guess? |
Yeah, and if that turns out to be more annoying than just waiting for the CI and landing them the normal way we can just revert it. |
No description provided.