Skip to content

Use CI skip on release-marking PRs #23165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Dec 14, 2024

No description provided.

@dschuff
Copy link
Member Author

dschuff commented Dec 14, 2024

How does [ci skip] work, anyway?

@dschuff dschuff requested a review from sbc100 December 16, 2024 16:21
@sbc100
Copy link
Collaborator

sbc100 commented Dec 16, 2024

How does [ci skip] work, anyway?

Its some kind of circle-ci or github actions specific string that causes the steps not to run.

I don't know that it also makes the "required" steps magically not required?

@dschuff dschuff changed the title Use CI skip on release-marking PRs Use CI skip on release-marking PRs [ci skip] Dec 16, 2024
@sbc100
Copy link
Collaborator

sbc100 commented Dec 16, 2024

I think [skip ci] does in the PR description normally, not in the title

@sbc100
Copy link
Collaborator

sbc100 commented Dec 16, 2024

@dschuff
Copy link
Member Author

dschuff commented Dec 16, 2024

Aha ok interesting it's not supported for fork PRs, that's why it's not working here.

@dschuff dschuff changed the title Use CI skip on release-marking PRs [ci skip] Use CI skip on release-marking PRs Dec 16, 2024
@dschuff
Copy link
Member Author

dschuff commented Dec 16, 2024

But that's a good point about branch protections; my guess would be that the PR won't be blocked by CI that isn't run; just by CI that fails.

@sbc100
Copy link
Collaborator

sbc100 commented Dec 16, 2024

But that's a good point about branch protections; my guess would be that the PR won't be blocked by CI that isn't run; just by CI that fails.

I'm not sure the circleci <-> github integration is smart enough to do that.. but I hope so.

@dschuff
Copy link
Member Author

dschuff commented Dec 16, 2024

Should we try this out and see what happens then? Do you want to LGTM?

@sbc100
Copy link
Collaborator

sbc100 commented Dec 16, 2024

We can always land these change by force I guess?

@dschuff
Copy link
Member Author

dschuff commented Dec 16, 2024

Yeah, and if that turns out to be more annoying than just waiting for the CI and landing them the normal way we can just revert it.

@dschuff dschuff merged commit ff1e239 into emscripten-core:main Dec 16, 2024
28 checks passed
hedwigz pushed a commit to hedwigz/emscripten that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants