Fix some source map and name section behavior #23182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) This causes -g0 to fullyl override -gsource-map (removing the name section) when it comes later on the command line 2) -gsplit-dwarf and -gsource-map work together resulting in dwarf, source maps and name section together.
sbc100
approved these changes
Dec 16, 2024
| @@ -3105,7 +3104,7 @@ def test_dwarf_sourcemap_names(self): | |||
| (['-sASYNCIFY=1', '-gsource-map'], False, True, True), | |||
| (['-g', '-gsource-map'], True, True, True), | |||
| (['-g2', '-gsource-map'], False, True, True), | |||
| # (['-gsplit-dwarf', '-gsource-map'], True, True, True), TODO this currently fails! | |||
| (['-gsplit-dwarf', '-gsource-map'], True, True, True), | |||
There was a problem hiding this comment.
Great to see these TODOs fixed!
| building.strip(infile, outfile, debug=not settings.GENERATE_DWARF, | ||
| sections=sections) | ||
| sections=strip_sections) |
There was a problem hiding this comment.
This code gives me a headache! LGTM though
There was a problem hiding this comment.
Yes, the possible combinations of debug options is pretty bad. But I think this (and the previous change, which added all those tests in test_other) is an improvement because it's now more explicit in the emscripten code rather than part of the behavior being implicit with Binaryen.
|
Part 1 is maybe worth a changelog mention? |
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
1) This causes -g0 to fullyl override -gsource-map (removing the name section) when it comes later on the command line 2) -gsplit-dwarf and -gsource-map work together resulting in dwarf, source maps and name section together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes -g0 to fullyl override -gsource-map (removing the name section)
when it comes later on the command line
-gsplit-dwarf and -gsource-map work together resulting in dwarf, source
maps and name section together.