Fix Sanitizer failures in FS tests #23243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a mode parameter to the open() call in test_fs_enotdir to avoid reading the uninitialized parameter when using O_CREAT * Add a call to closedir pair the call to fdopendir in in test_fs_readdir_ino_matches_stat_ino, which allows the implementation to free the underlying stream and make LSan happy.
kripken
approved these changes
Dec 20, 2024
|
No worries. This happens because we don't run the sanitizers until after the changes make it over to Chromium. Arguably the latter change also shouldn't be necessary, under the usual model where the process gets cleaned up on exit. fdopendir is a little weird since the spec doesn't seem to guarantee that an underlying allocation happens, but it does anyway. It seemed easier to just do this than to try to make LSan happier in general with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reading the uninitialized parameter when using O_CREAT
test_fs_readdir_ino_matches_stat_ino, which allows the implementation to
free the underlying stream and make LSan happy.