Disable test_fcntl_open on MacOS #23244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was disabled on Windows in emscripten-core#23241 but fails on MacOS too.
kripken
approved these changes
Dec 20, 2024
Co-authored-by: Alon Zakai <[email protected]>
sbc100
reviewed
Dec 22, 2024
| if '-DNODERAWFS' in self.emcc_args and WINDOWS: | ||
| self.skipTest('currently failing under windows and noderawfs') | ||
| if '-DNODERAWFS' in self.emcc_args and not LINUX: | ||
| self.skipTest('noderawfs fails here under non-linux') |
There was a problem hiding this comment.
Why didn't this fail in emscripten CI? We run all the crossplatform tests on macOS there I believe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was disabled on Windows in #23241 but fails on MacOS too.