Disable test_unistd_unlink_wasmfs_rawfs on mac #23856
Conversation
|
I don't know if it's ever worked but we aren't testing it currently (I am planning to move Chromium CI's core2 tests from windows to mac) |
| @@ -5989,11 +5989,11 @@ def test_unistd_sysconf_phys_pages(self): | |||
| def test_unistd_unlink(self): | |||
| # symlinks on node.js on non-linux behave differently (e.g. on Windows they require administrative privileges) | |||
| # so skip testing those bits on that combination. | |||
| if any([arg in self.emcc_args for arg in ('-DNODEFS', '-DNODERAWFS')]) and MACOS: | |||
| self.skipTest('only tested on linux') | |||
There was a problem hiding this comment.
Can you also add @crossplatform so that it would fail without this change in our CI?
There was a problem hiding this comment.
I think can you elide the square brackets here.
Also, I think it might be easier to read if MACOS came before the any statement.
There was a problem hiding this comment.
Maybe, but it's a little bit silly to add @crossplatform to a test that only works on one platform?
There was a problem hiding this comment.
(this will fail on Chromium CI without the change, that's how I noticed it)
There was a problem hiding this comment.
Right.. I just want to make sure we could also get the same failure here.
We can then work to remove the skipping part over time (perhaps).
|
Ping? |
No description provided.