Reduce non-highmem browser testing #23911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the number of tests run in the "default" browser test modes (i.e. non-2g 32bit and non-4g 64-bit). The idea is that the set of edge cases covered by the 2g and 4g modes is basically a superset of those covered by the default cases. Tests that are disabled in the 2g and 4g modes are still run in the default modes.
|
This does still keep some tests running in the default modes, just to make sure that no tests are skipped entirely. |
kripken
approved these changes
Mar 12, 2025
sbc100
reviewed
Mar 12, 2025
|
test_2gb_fail, test_4gb_fail and test_2gb are failing here in test-browser-chrome-wasm64. Were they working before? |
|
oh nevermind, they were skipped before. |
The 4gb_fail test looks like it was deliberately skipped (your removed that line). |
kripken
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of tests run in the "default" browser test modes
(i.e. non-2g 32bit and non-4g 64-bit). The idea is that the set of edge
cases covered by the 2g and 4g modes is basically a superset of those
covered by the default cases. Tests that are disabled in the 2g and 4g
modes are still run in the default modes.