[libbrowser.js] Remove non-standard Module exports #24269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
browser_aliases
branch
2 times, most recently
from
08ffdbe to
ea9fa80
Compare
sbc100
added a commit
to sbc100/SDL
that referenced
this pull request
May 6, 2025
The Module interface is the one used by the outside world. This code is inside the module itself so can use the internal name, avoiding the need to export this function on the Module at all. See emscripten-core/emscripten#24269
kripken
reviewed
May 6, 2025
slouken
pushed a commit
to libsdl-org/SDL
that referenced
this pull request
May 6, 2025
The Module interface is the one used by the outside world. This code is inside the module itself so can use the internal name, avoiding the need to export this function on the Module at all. See emscripten-core/emscripten#24269
slouken
pushed a commit
to libsdl-org/SDL
that referenced
this pull request
May 6, 2025
The Module interface is the one used by the outside world. This code is inside the module itself so can use the internal name, avoiding the need to export this function on the Module at all. See emscripten-core/emscripten#24269 (cherry picked from commit 8e1f4ba)
sbc100
force-pushed
the
browser_aliases
branch
2 times, most recently
from
170e2df to
98890a7
Compare
|
Combined with the existing changelog entry that did the same thing for embind symbols. |
kripken
reviewed
May 6, 2025
Anyone who wants to use these functions on the Module object can export them using e.g. `-sEXPORTED_FUNCTIONS=getUserMedia`. As part of this I had to inject the export of `createContext` for SDL2 and SDL3 which were using `Module['createContext']` for some reason. I'm working on upstream patches to remove this usage.
kripken
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone who wants to use these functions on the Module object can
export them using e.g.
-sEXPORTED_FUNCTIONS=getUserMedia.As part of this I had to inject the export of
createContextfor SDL2and SDL3 which were using
Module['createContext']for some reason.I'm working on upstream patches to remove this usage.