Fix computed checks in acorn-optimizer. NFC
#24271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
May 6, 2025
|
How hard would it be to write a test for this? |
Hard enough that I don't even want to start thinking about it 😅 |
Because constructing some JS to tickle this would be hard or because of unfamiliarity with the unit tests we have for JSDCE? |
This one. In theory, it might be doable with enough effort, but for now I'm focused on some larger changes and don't want to dig into this potential edge cases that no one even ran into so far. |
|
Fair enough lgtm! |
`.computed` is a property of `MemberExpression`, but in a few cases it was incorrectly checked on `CallExpression`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.computedis a property ofMemberExpression, but in a few cases it was incorrectly checked onCallExpressions.This doesn't cause issues in existing tests, mostly noticed as a drive-by fix.