[esm-integration] Fix handling of EM_JS exports #24292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
esm_integration_em_js
branch
2 times, most recently
from
72f6844 to
694fd91
Compare
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api. As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode. Split out from emscripten-core#24288 See emscripten-core#24060
sbc100
force-pushed
the
esm_integration_em_js
branch
from
694fd91 to
c80eda9
Compare
dschuff
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also adds a new core test mode for ESM integration and uses this to run all the variants of test_fs_js_api.
As part of this I also updated the octal constants in test_fs_js_api.c which are required to be of the new form in strict JS. All code in ES modules is implicitly in strict mode.
Split out from #24288
See #24060