Skip to content

Conversation

@mtschammer
Copy link
Contributor

The createand update methods in BaseSerializerand ListSerializer both take validated_dataas an argument. Those same methods on ModelSerializer, however, take validated_attrs. This is confusing, especially considering that validated_data is used in the documentation for the changelog.

@lovelydinosaur
Copy link
Contributor

Yup, good spot - should be validated_data throughout.
Your fix shouldn't be a breaking change, as anyone re-implementing these will have declared the signature themselves, so this looks good to me. Thanks!

lovelydinosaur added a commit that referenced this pull request Dec 3, 2014
…ename

Renamed validated_attrs to validated_data to be more in line with other code
@lovelydinosaur lovelydinosaur merged commit f221b73 into encode:master Dec 3, 2014
@lovelydinosaur lovelydinosaur added this to the 3.0.1 Release milestone Dec 3, 2014
@mtschammer
Copy link
Contributor Author

Happy to help! :)

This was referenced Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants