Fix UnicodeDecodeError, which can occur on serializer repr.
#2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Isn't this line enough for both py2 and py3 ?
There was a problem hiding this comment.
No. Python 2 expects repr to return str values. Given that we're using unicode throughout, we need to forcibly coerce those immediate prior to returning the values.
There was a problem hiding this comment.
Forget about my previous comment, I was doing conversions the wrong way in the repr.
lovelydinosaur
added a commit
that referenced
this pull request
Dec 15, 2014
…-bug Use unicode internally everywhere for 'repr'.
lovelydinosaur
changed the title
UnicodeDecodeError, which can occur on serializer repr.
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
This was referenced Nov 6, 2017
This was referenced Dec 10, 2017
This was referenced Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2270.
We're now using unicode internally everywhere when building the
reprand only coercing to str (for python 2) immediately prior to returning.