Fix lookup_url_kwarg handling in viewsets (Fixes #2591). #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ``lookup_url_kwarg`` is intended to set the name of a field in the URL regexps when using custom ``lookup_field``, but the routers ignore it altogether.
xordoquy
added a commit
that referenced
this pull request
Mar 13, 2015
Fix lookup_url_kwarg handling in viewsets (Fixes #2591).
|
Thanks for the fix. |
|
Great! |
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
This was referenced Nov 6, 2017
This was referenced Nov 14, 2017
This was referenced Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lookup_url_kwargis intended to set the name of a field in theURL regexps when using custom
lookup_field, but the routers ignoreit altogether.
When a ViewSet is defined with:
Then we should get an URL along the lines of
/profiles/(?P<username>[^./]+)/.However, we get
/profiles/(?P<user__username>[^./]+)/...This PR fixes the bug (reported as #2591), along with an inelegant test.