add default value to model serializer #2714
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as I explained in #2683, the default value is not being passed in the model serializer.
I understand your argument that this is not required functionality-wise, but it is a problem when auto generation documentation (e.g. with django-rest-swagger). This was the behavior in djangorestframework==2.3.8, in which the swagger tests are run against.
I don't see any disadvantage in passing the default value to the field, instead of just marking it as non required.
Do you see any?
Please reconsider.