Add missing csrf_token in AdminRenderer post form. #3703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks legit for me but I'll ask another to review that as I haven't played with AdminRenderer yet. |
|
There are several forms (I grepped for POST-forms) that don't have {% csrf_token %} in them. |
xordoquy
added a commit
that referenced
this pull request
Jan 19, 2016
Add missing csrf_token in AdminRenderer post form.
|
Thanks, just gave this a try and indeed creation didn't work. |
|
@atombrella feel free to open another PR if you can spot missing CSRF. |
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSRF token was missing during object creation through Create form in AdminRenderer. An analogous csrf_token tag in the base browsable API form was introduced in 41182c6.