Skip to content

Issue 5220 #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Issue 5220 #5239

wants to merge 2 commits into from

Conversation

@vimarshc
Copy link
Contributor

@vimarshc vimarshc commented Jun 28, 2017 •
edited
Loading

Description

The PR includes a testcase for issue #5220 as well as a preliminary fix. What that means is that the fix is working but I believe it could be done in a better way.

rpkilby
rpkilby reviewed Jun 28, 2017
View reviewed changes
Copy link
Contributor

@rpkilby rpkilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vimarshc. The second commit makes a number of minor style changes to test_model_serializer.py. If you simply remove those from the commit, the linter should be appeased.

@lovelydinosaur lovelydinosaur mentioned this pull request Jul 10, 2017
Merged
@vimarshc vimarshc deleted the issue-5220 branch August 22, 2017 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rpkilby rpkilby rpkilby left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vimarshc @rpkilby