Skip to content

Add blockcode warnings #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Add blockcode warnings #119

merged 3 commits into from
Jul 5, 2024

Conversation

dylanmccall
Copy link
Contributor

@dylanmccall dylanmccall commented Jul 5, 2024

This adds some new warnings to BlockCode to deal with common problems users may encounter:

Screenshot from 2024-07-05 13-06-08

Note that the "parent should only contain on BlockCode" warning also occurs when the parent is a separate (instantiated) scene. I simulated that in the screenshot by adding a BlockCode node to space.tscn, so in pong_game.tscn, where I added another BlockCode under Space, we get a warning.

Copy link
Contributor

@wnbaum wnbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good thinking about BlockCode nodes that could be attached in instantiated scenes. Looks good to me.

@wnbaum wnbaum merged commit b7cbac1 into main Jul 5, 2024
2 checks passed
@wnbaum wnbaum deleted the add-blockcode-warnings branch July 5, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants