Change Simple node scripts to instantiate themselves #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starnight
requested changes
Jul 17, 2024
| @@ -19,6 +19,13 @@ const _POSITIONS_FOR_PLAYER = { | |||
| } | |||
|
|
|||
|
|
|||
| func _init(): | |||
| var node = preload("res://addons/block_code/simple_nodes/simple_scoring/_simple_scoring.tscn").instantiate() as Node | |||
| node.replace_by(self, true) | |||
There was a problem hiding this comment.
When I play the Pong game, it shows error:
E 0:00:00:0452 simple_scoring.gd:24 @ _init(): Condition "p_node->data.parent" is true.
<C++ Source> scene/main/node.cpp:2796 @ replace_by()
<Stack Trace> simple_scoring.gd:24 @ _init()
block_code.gd:56 @ _update_parent_script()
block_code.gd:14 @ _ready()
There was a problem hiding this comment.
Ooh, I see how that happened. That's fixed in the newest set of commits.
| @@ -52,6 +52,13 @@ func on_gravity_changed(new_gravity): | |||
| gravity = new_gravity | |||
|
|
|||
|
|
|||
| func _init(): | |||
| var node = preload("res://addons/block_code/simple_nodes/simple_character/_simple_character.tscn").instantiate() as Node | |||
| node.replace_by(self, true) | |||
There was a problem hiding this comment.
When I play the Pong game, it shows error:
E 0:00:00:0445 simple_character.gd:57 @ _init(): Condition "p_node->data.parent" is true.
<C++ Source> scene/main/node.cpp:2796 @ replace_by()
<Stack Trace> simple_character.gd:57 @ _init()
block_code.gd:56 @ _update_parent_script()
block_code.gd:14 @ _ready()
To support users adding SimpleCharacter and SimpleScoring as nodes, instead of as child scenes, add an _init function for each which loads the appropriate scene file and instantiates it. https://phabricator.endlessm.com/T35545
dylanmccall
force-pushed
the
T35545-instantiate-simple-nodes
branch
from
065a94d to
5893a5a
Compare
manuq
approved these changes
Jul 17, 2024
Comment on lines
+5
to
+8
| func _init(): | ||
| # Disable the SimpleCharacter _init function. We expect this script is | ||
| # already bound to _simple_character.tscn. | ||
| pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support users adding SimpleCharacter and SimpleScoring as nodes, instead of as child scenes, add an _init function for each which loads the appropriate scene file and instantiates it.
https://phabricator.endlessm.com/T35545